Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crmsh-4.6] Fix: sh: guide users to setup key-based ssh authentication when non-interactive authentcation fails (bsc#1219045) #1309

Merged
merged 1 commit into from
Jan 24, 2024
Merged

[crmsh-4.6] Fix: sh: guide users to setup key-based ssh authentication when non-interactive authentcation fails (bsc#1219045) #1309

merged 1 commit into from
Jan 24, 2024

Conversation

nicholasyang2022
Copy link
Collaborator

No description provided.

@nicholasyang2022
Fix: sh: guide users to setup key-based ssh authentication when
03a9250 
non-interactive authentcation fails (bsc#1219045)
@nicholasyang2022 nicholasyang2022 changed the title Fix: sh: guide users to setup key-based ssh authentication when non-interactive authentcation fails (bsc#1219045) [crmsh-4.6] Fix: sh: guide users to setup key-based ssh authentication when non-interactive authentcation fails (bsc#1219045) Jan 22, 2024
@nicholasyang2022
Copy link
Collaborator Author

Example ouput:

suse@ha-1-2:~> sudo crm cluster stop --all
ERROR: cluster.stop: Failed to run command systemctl is-active 'corosync.service' on root@ha-1-1: root@ha-1-1: Permission denied (publickey,password,keyboard-interactive). Please configure passwordless authentication with "crm cluster init ssh" and "crm cluster join ssh"

@codecov Codecov
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (1eb5327) 52.66% compared to head (03a9250) 52.66%.

Files Patch % Lines
crmsh/sh.py 30.00% 7 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##           crmsh-4.6    #1309      +/-   ##
=============================================
- Coverage      52.66%   52.66%   -0.01%     
=============================================
  Files             79       79              
  Lines          23938    23942       +4     
=============================================
+ Hits           12607    12609       +2     
- Misses         11331    11333       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicholasyang2022 nicholasyang2022 marked this pull request as ready for review January 22, 2024 05:43
@nicholasyang2022
Copy link
Collaborator Author

@liangxin1300 Key-swap related code cannot be covered in functional tests, leading to low coverage of the patch. If there are no problems with this patch, we can merge it manually.

@liangxin1300 liangxin1300 merged commit feea55a into ClusterLabs:crmsh-4.6 Jan 24, 2024
30 of 31 checks passed
@nicholasyang2022 nicholasyang2022 deleted the bsc_1219045_4.6 branch January 25, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangxin1300 liangxin1300 liangxin1300 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholasyang2022 @liangxin1300